[#171703313] SAML certs and Startup IDP metadata from ENV #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 82.7% 82.75% +0.05%
==========================================
Files 48 48
Lines 1376 1386 +10
Branches 241 242 +1
==========================================
+ Hits 1138 1147 +9
- Misses 227 228 +1
Partials 11 11
Continue to review full report at Codecov.
|
gunzip
reviewed
Mar 10, 2020
| @@ -116,7 +135,8 @@ export const appConfig: IApplicationConfig = { | |||
| clientLoginRedirectionUrl: CLIENT_REDIRECTION_URL, | |||
| loginPath: "/login", | |||
| metadataPath: "/metadata", | |||
| sloPath: "/slo" | |||
| sloPath: "/slo", | |||
| startupIdpsMetadata: STARTUP_IDPS_METADATA | |||
There was a problem hiding this comment.
can you please document this var into th readme ?
There was a problem hiding this comment.
Fixed in 53626f2
gunzip
reviewed
Mar 10, 2020
| @@ -170,7 +171,7 @@ export function newApp( | |||
| // Setup routes | |||
| // | |||
|
|
|||
| return tryCatch(async () => { | |||
| return new Task(async () => { | |||
There was a problem hiding this comment.
we must ensure that this code never throws
There was a problem hiding this comment.
Are all static methods inside the Task that should never throw. I think that tryCatch before and new Task now, are only for chaining purposes with withSpid.
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
gunzip
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.