Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#172038263] Add Express Error Middleware, catch passport exceptions #632

Merged
merged 14 commits into from
Apr 7, 2020

Conversation

BurnedMarshal
Copy link
Contributor

No description provided.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Apr 7, 2020

Warnings
⚠️

Please include a description of your PR changes.

Affected stories

  • ⚙️ #172038263: Controllare che tutti i controller gestiscano correttamente le eccezioni

Generated by 🚫 dangerJS

src/app.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
@@ -29,10 +29,20 @@ const bearerSessionTokenStrategy = (
) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about bearerWalletTokenStrategy ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 67317c1

src/utils/middleware/express.ts Outdated Show resolved Hide resolved
BurnedMarshal and others added 5 commits April 7, 2020 14:25
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
Co-Authored-By: Danilo Spinelli <gunzip@users.noreply.github.com>
@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

Merging #632 into master will decrease coverage by 0.04%.
The diff coverage is 39.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   82.42%   82.37%   -0.05%     
==========================================
  Files          51       53       +2     
  Lines        1485     1515      +30     
  Branches      247      254       +7     
==========================================
+ Hits         1224     1248      +24     
- Misses        250      256       +6     
  Partials       11       11              
Impacted Files Coverage Δ
src/server.ts 0.00% <0.00%> (ø)
src/strategies/bearerSessionTokenStrategy.ts 41.17% <12.50%> (+3.67%) ⬆️
src/strategies/bearerWalletTokenStrategy.ts 41.17% <12.50%> (+3.67%) ⬆️
src/utils/strategies.ts 20.00% <20.00%> (ø)
src/utils/middleware/express.ts 42.85% <42.85%> (ø)
src/services/pagoPAClientFactory.ts 63.63% <57.14%> (+8.08%) ⬆️
src/utils/appinsights.ts 89.47% <60.00%> (-10.53%) ⬇️
src/services/apiClientFactory.ts 71.42% <75.00%> (+11.42%) ⬆️
src/app.ts 95.09% <100.00%> (+0.06%) ⬆️
src/config.ts 80.76% <100.00%> (+0.37%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18942d6...ba103e0. Read the comment docs.

@BurnedMarshal BurnedMarshal requested a review from gunzip April 7, 2020 13:37
src/utils/strategies.ts Outdated Show resolved Hide resolved
@gunzip gunzip merged commit bbeaf16 into master Apr 7, 2020
@gunzip gunzip deleted the 172038263-express-error-middleware branch April 7, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants