Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#173182873] await on installation promise #673

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gunzip
Copy link
Contributor

@gunzip gunzip commented Jun 4, 2020

No description provided.

@gunzip gunzip requested a review from francescopersico as a code owner June 4, 2020 20:57
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jun 4, 2020

Warnings
⚠️

Please include a description of your PR changes.

Affected stories

  • 🐞 #173182873: Le push notification non arrivano a destinazione

Generated by 🚫 dangerJS

@codecov-commenter
Copy link

Codecov Report

Merging #673 into master will increase coverage by 0.03%.
The diff coverage is 82.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   78.11%   78.14%   +0.03%     
==========================================
  Files          61       61              
  Lines        1919     1913       -6     
  Branches      327      327              
==========================================
- Hits         1499     1495       -4     
+ Misses        408      406       -2     
  Partials       12       12              
Impacted Files Coverage Δ
src/app.ts 90.55% <0.00%> (ø)
src/clients/bonus.ts 53.84% <33.33%> (ø)
src/services/bonusService.ts 78.35% <86.66%> (ø)
src/controllers/bonusController.ts 100.00% <100.00%> (ø)
src/controllers/notificationController.ts 100.00% <100.00%> (+5.71%) ⬆️
src/services/notificationService.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fb66a...17e4e34. Read the comment docs.

@gunzip gunzip added the on-hold label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants