Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#173289855] Deploy pipeline change with new app backend #681

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

uolter
Copy link
Member

@uolter uolter commented Jun 12, 2020

@raicastino before merge this branch to master we need:

  • rename the variable: PRODUCTION_APP_NAME to PRODUCTION_BACKEND_APP_NAME
  • add a new variable PRODUCTION_BACKENDBONUS_APP_NAME with value io-p-app-appbackendbonus

@uolter uolter requested a review from raicastino June 12, 2020 07:53
@codecov-commenter
Copy link

Codecov Report

Merging #681 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   78.04%   78.04%           
=======================================
  Files          62       62           
  Lines        1945     1945           
  Branches      325      325           
=======================================
  Hits         1518     1518           
  Misses        415      415           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaa1c7c...5019e77. Read the comment docs.

@uolter uolter changed the title 173289855 deploy pipeline change [#173289855] Deploy pipeline change with new app backend Jun 12, 2020
@pagopa-github-bot
Copy link
Contributor

Affected stories

  • 🌟 #173289855: Modificare la pipeline per il deploy di appbackend

Generated by 🚫 dangerJS

Copy link
Contributor

@raicastino raicastino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok! Just change the pipeline description with the new variables names (the comment at the beginning of the file).

@gunzip gunzip added the on-hold label Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants