Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#176003320] Return 500 instead of 401 on system errors #728

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

gunzip
Copy link
Contributor

@gunzip gunzip commented Dec 3, 2020

Atm the passport middleware returns 401 in case of system errors; it must return 500 otherwise the user is logged out.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Dec 3, 2020

Affected stories

  • 🐞 #176003320: Quando le chiamate a redis falliscono per un errore di sistema o timeout, il controller NON deve tornare 401 ma 500

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #728 (c77244f) into master (2e70348) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files          69       69           
  Lines        2281     2281           
  Branches      383      383           
=======================================
  Hits         1833     1833           
  Misses        435      435           
  Partials       13       13           
Impacted Files Coverage Δ
src/utils/strategies.ts 20.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddafb0...c77244f. Read the comment docs.

@gunzip gunzip marked this pull request as draft December 3, 2020 23:22
@gunzip gunzip marked this pull request as ready for review December 4, 2020 06:49
@gunzip gunzip merged commit d2316d8 into master Dec 4, 2020
@gunzip gunzip deleted the 176003320-401-to-500 branch December 4, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants