Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-86] Eslint migration, new rules and less comments #134

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

  • Updated eslint-rules to 1.3.1
  • Removed useless rule disabling comment

Motivation and Context

We want to have as less rule disabling comments as possible for @typescript-eslint/naming-convention rule.

How Has This Been Tested?

It has been tested by performing:

  • yarn install --frozen-lockfile
  • yarn build
  • yarn lint
  • yarn test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #134 (23ac1d0) into master (58fda03) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   84.20%   84.10%   -0.10%     
==========================================
  Files          49       49              
  Lines        1665     1655      -10     
  Branches      133      133              
==========================================
- Hits         1402     1392      -10     
  Misses        258      258              
  Partials        5        5              
Impacted Files Coverage Δ
CreateService/handler.ts 85.18% <ø> (ø)
CreateSubscription/handler.ts 92.15% <ø> (ø)
CreateUser/handler.ts 87.17% <ø> (ø)
DeleteUserDataActivity/types.ts 100.00% <ø> (ø)
GetService/handler.ts 86.95% <ø> (ø)
GetServices/handler.ts 84.84% <ø> (ø)
GetSubscriptionKeys/handler.ts 85.18% <ø> (ø)
GetUsers/handler.ts 88.57% <ø> (ø)
Info/handler.ts 83.33% <ø> (ø)
RegenerateSubscriptionKeys/handler.ts 85.71% <ø> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9f07b...23ac1d0. Read the comment docs.

@balanza balanza merged commit 63007f6 into master Apr 19, 2021
@balanza balanza deleted the ip-86-tslint2eslint branch April 19, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants