[#IC-303] Add Message View to User Data Extract and Delete #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleDore
requested review from
michaeldisaro,
domenicoventriglia,
CaraDune,
fabriziopapi and
gquadrati
and removed request for
a team
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
|
I'm not sure if the "extract" part is strictly required. |
fabriziopapi
approved these changes
Apr 26, 2022
gquadrati
approved these changes
Apr 26, 2022
ExtractUserDataActivity/handler.ts
Outdated
Comment on lines
410
to
427
| messagesView: pipe( | ||
| messageViewModel.getQueryIterator({ | ||
| parameters: [ | ||
| { | ||
| name: "@fiscalCode", | ||
| value: fiscalCode | ||
| } | ||
| ], | ||
| query: `SELECT * FROM m WHERE m.fiscalCode = @fiscalCode | ||
| ORDER BY m.fiscalCode, m.id DESC` | ||
| }), | ||
| TE.of, | ||
| TE.chain(iterable => | ||
| TE.tryCatch( | ||
| () => asyncIterableToArray(iterable), | ||
| toCosmosErrorResponse | ||
| ) | ||
| ), |
There was a problem hiding this comment.
asyncIterableToArray or asyncIteratorToArray?
| expect(E.isRight(result)).toBe(true); | ||
| }); | ||
|
|
||
| it("should stop if there is an error while looking for a message View (404)", async () => { |
There was a problem hiding this comment.
Add
expect(mockDeleteMessageView).not.toHaveBeenCalled();
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
This PR is needed by legal behaviour in order to manage new
message-viewcollection, introduced by pagination.How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Types of changes
Checklist: