[#IOCIT-105] added servicesPreferences to profile data download #191
Conversation
arcogabbo
requested review from
michaeldisaro and
domenicoventriglia
and removed request for
a team
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
| @@ -255,7 +291,8 @@ describe("createExtractUserDataActivityHandler", () => { | |||
| notificationStatusModel: notificationStatusModelMock, | |||
| profileModel: profileModelMock, | |||
| userDataBlobService: blobServiceMock, | |||
| userDataContainerName: aUserDataContainerName | |||
| userDataContainerName: aUserDataContainerName, | |||
| servicePreferencesModel | |||
There was a problem hiding this comment.
I'd maintain coherence keeping or servicePreferencesModel: servicePreferencesModel or servicePreferencesModel alone. Also mocks have usually a "Mock" suffix.
utils/__tests__/userData.test.ts
Outdated
| if (E.isRight(result)) { | ||
| expect(result.right).toMatchObject(mockedUserData); | ||
| expect( | ||
| (result.right.servicesPreferences[0] as any).foo |
There was a problem hiding this comment.
Maybe you could just check that they are equal to aServicePreference.
ExtractUserDataActivity/handler.ts
Outdated
| servicePreferencesModel.findAllByFiscalCode(fiscalCode), | ||
| flattenAsyncIterator, | ||
| asyncIteratorToArray, | ||
| promise => |
There was a problem hiding this comment.
Can't we just use fromPromiseEither or define something similar?
There was a problem hiding this comment.
Isn't clear to me what do you mean with fromPromiseEither. In here we have a Promise<ReadonlyArray<Either>> and the Eithers are not relevant in the TE transformation. IMHO the tryCatch is the best method to transform a Promise to a TE where the left value is obtained only on the promise failure.
There was a problem hiding this comment.
i created another function because the promise mentioned above was returning an either[]. done in 1403000
There was a problem hiding this comment.
I meant that there was a utility function above and maybe we could have adapted it to be more general. The function is using tryCatch but taking it outside the pipe.
There was a problem hiding this comment.
I think that with a separated function the code is less readable in this case, but i leave on you @michaeldisaro @arcogabbo
There was a problem hiding this comment.
On new functions pls add a detailed JS doc :D
Co-authored-by: burnedmarshal <dan.manni@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
i just run it and it works as expected |
List of Changes
Added
servicesPreferencesfield toAllUserDatatypeI did a mini refactor on the pipeline for the user data fetch replacing some
sequenceSwithbindstructure where parallel tasks wasn't neededMotivation and Context
At the moment the servicesPreferences of a profile are not being added to the data a user downloads their data
How Has This Been Tested?
The entire flow of adding some preferences and downloading the data was tested through the
io-mockprojectTests passing
The delete procedure already eliminates the preferences, so testing wasn't needed in that front.
Screenshots (if appropriate):
Types of changes
Checklist: