[#IOPSC-118] Respond with 'too many requests' status code when creating too much subscriptions for the same account #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
requested review from
BurnedMarshal and
domenicoventriglia
and removed request for
a team
balanza
changed the title
balanza
requested review from
LoFrance and
iwoak
and removed request for
domenicoventriglia
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
|
Kudos, SonarCloud Quality Gate passed!
|
LoFrance
suggested changes
Dec 13, 2022
Comment on lines
+178
to
+188
| if (error === null) { | ||
| return false; | ||
| } | ||
| if (!(error instanceof RestError)) { | ||
| return false; | ||
| } | ||
| if (!error.statusCode) { | ||
| return false; | ||
| } | ||
|
|
||
| return error.statusCode === statusCode; |
There was a problem hiding this comment.
Why not in fp-ts?
flow(
E.fromPredicate(
() =>
error instanceof RestError &&
error.statusCode === statusCode,
() => false
),
E.fold(
identity,
(_) => true
)
)(error);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
See commit list
Motivation and Context
Azure API Management may fail to create too many subscriptions for the same account. According to Microsoft support, this is due to its internal optimistic consistency mechanism. Such failures do not depend on us or on a specific traffic pattern and are non-deterministic from our perspective; nevertheless, they are treated as generic server errors 500 and are hard to be monitored apart and react to differently.
To improve our users' experience we decided to:
subscriptions.createOrUpdateoperation when a 412 error is returned, so our users do not have to care about anything at the cost of a slightly-higher response timeHow Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: