Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#172621882] small refactor: generate zip with user data #47

Merged
merged 4 commits into from
May 16, 2020

Conversation

gunzip
Copy link
Contributor

@gunzip gunzip commented May 16, 2020

  • handle archive (zip) promise
  • fix unit tests

@gunzip gunzip requested a review from balanza May 16, 2020 09:13
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented May 16, 2020

Affected stories

  • 🌟 #172621882: Come CIT, quando esprimo la volontà di scaricare i miei dati, voglio ricevere un link per il download dei dati entro 7gg dalla richiesta

Generated by 🚫 dangerJS

danilo spinelli added 2 commits May 16, 2020 12:04
@codecov-io
Copy link

codecov-io commented May 16, 2020

Codecov Report

Merging #47 into master will decrease coverage by 2.57%.
The diff coverage is 76.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   88.81%   86.24%   -2.58%     
==========================================
  Files          21       25       +4     
  Lines         608      807     +199     
  Branches       37       50      +13     
==========================================
+ Hits          540      696     +156     
- Misses         67      110      +43     
  Partials        1        1              
Impacted Files Coverage Δ
CreateService/handler.ts 85.18% <0.00%> (ø)
UpdateService/handler.ts 90.47% <0.00%> (ø)
GetService/handler.ts 86.95% <50.00%> (+3.62%) ⬆️
utils/zip.ts 53.33% <53.33%> (ø)
ExtractUserDataActivity/handler.ts 77.61% <77.61%> (ø)
utils/random.ts 77.77% <77.77%> (ø)
SetUserDataProcessingStatusActivity/handler.ts 88.09% <88.09%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285cd2e...5ae6321. Read the comment docs.

@balanza
Copy link
Contributor

balanza commented May 16, 2020

@gunzip I agree on everything but the dismissal of the test about sensitive data (notification webhook url). I prepared an addendum on this branch in #48, I think we should merge that before merging this.

@gunzip gunzip merged commit 6cdb6dd into master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants