[#174644239] - Fix GetServices returns all services #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunzip
reviewed
Sep 4, 2020
GetServices/handler.ts
Outdated
Comment on lines
87
to
92
| const reducedResults = results.reduce((prev, curr) => { | ||
| return { | ||
| ...prev, | ||
| ...curr | ||
| }; | ||
| }, {}); |
There was a problem hiding this comment.
what's the purpose of this code?
There was a problem hiding this comment.
results' type is {}[]. I've used reduce to flatten results into {}
There was a problem hiding this comment.
nevermind, changed implementation in 85a8305
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 86.62% 86.13% -0.50%
==========================================
Files 39 39
Lines 1249 1255 +6
Branches 88 97 +9
==========================================
- Hits 1082 1081 -1
- Misses 166 172 +6
- Partials 1 2 +1
Continue to review full report at Codecov.
|
Affected stories
Generated by 🚫 dangerJS |
gunzip
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fix to GetServices that now returns all services, instead of a subset.
This also includes specs update on GetServices return type.