Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174844930] Restrict subscription(s) output payload properties #80

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Sep 16, 2020

This PR:

  • modifies the Subscription' s property id mapping.
  • modifies Subscription' s definition in order to remove unnecessary properties

@AleDore AleDore requested review from gunzip and francescopersico and removed request for francescopersico September 16, 2020 15:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #80 into master will decrease coverage by 1.64%.
The diff coverage is 81.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   86.62%   84.98%   -1.65%     
==========================================
  Files          39       41       +2     
  Lines        1249     1365     +116     
  Branches       88      114      +26     
==========================================
+ Hits         1082     1160      +78     
- Misses        166      200      +34     
- Partials        1        5       +4     
Impacted Files Coverage Δ
DeleteUserDataActivity/utils.ts 34.21% <50.00%> (ø)
utils/conversions.ts 81.48% <60.00%> (-7.16%) ⬇️
ExtractUserDataActivity/handler.ts 76.38% <68.57%> (-1.63%) ⬇️
DeleteUserDataActivity/backupAndDelete.ts 92.85% <87.09%> (ø)
GetServices/handler.ts 84.84% <94.73%> (-0.34%) ⬇️
CreateService/handler.ts 85.18% <100.00%> (ø)
GetService/handler.ts 86.95% <100.00%> (ø)
GetUserDataProcessingActivity/handler.ts 90.90% <100.00%> (-0.21%) ⬇️
SetUserDataProcessingStatusActivity/handler.ts 89.47% <100.00%> (+1.10%) ⬆️
UpdateService/handler.ts 89.18% <100.00%> (-1.29%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59e37c...936701b. Read the comment docs.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Sep 16, 2020

Affected stories

  • 🌟 #174844930: Come SAS, voglio poter ricevere la lista di tutti gli identificativi dei servizi (subscriptions) associati alla mia utenza

Generated by 🚫 dangerJS

@gunzip gunzip changed the title [#174844930] Modifying subscription id mapping [#174844930] Restrict subscription(s) output payload properties Sep 16, 2020
@gunzip gunzip merged commit 7035dfb into master Sep 16, 2020
@gunzip gunzip deleted the 174844930_map_subscription_id_properly branch September 16, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants