-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#175395536] Add upload Organization Logo #96
Conversation
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 83.02% 83.10% +0.07%
==========================================
Files 48 49 +1
Lines 1626 1669 +43
Branches 126 126
==========================================
+ Hits 1350 1387 +37
- Misses 271 277 +6
Partials 5 5
Continue to review full report at Codecov.
|
I'm thinking about api design and keep our interface in good shape. I see we introduced the (*) I'm not saying we have to, I'm just exploring the domain. |
It's a good point. I've used |
there's some long term plan to have organizations as modelled entities so it's ok to have such an endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds a brand new operation:
UploadOrganizationLogo
, that is similar toÙploadServiceLogo
but it is intended only for organization logos, that can be different from services logos.