Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175395536] Add upload Organization Logo #96

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Oct 26, 2020

This PR adds a brand new operation: UploadOrganizationLogo, that is similar to ÙploadServiceLogo but it is intended only for organization logos, that can be different from services logos.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Oct 26, 2020

Affected stories

  • 🌟 #175395536: Come SAS, voglio poter caricare l' immagine relativa al logo dell' organizzazione utilizzando le API di onboarding programmatico dei servizi.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #96 into master will increase coverage by 0.07%.
The diff coverage is 86.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   83.02%   83.10%   +0.07%     
==========================================
  Files          48       49       +1     
  Lines        1626     1669      +43     
  Branches      126      126              
==========================================
+ Hits         1350     1387      +37     
- Misses        271      277       +6     
  Partials        5        5              
Impacted Files Coverage Δ
UploadOrganizationLogo/handler.ts 86.04% <86.04%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b550e...4932409. Read the comment docs.

@balanza
Copy link
Contributor

balanza commented Oct 26, 2020

I'm thinking about api design and keep our interface in good shape.

I see we introduced the /organizations sub path for our endpoints. This let me think we now have a new concept, Organization, and it might make sense to have concept-specific functionalities such as getOrganization, createOrganization, etc (*).
Is it the case? if so, I'm fine with the decision of organising endpoints like that. Otherwise, wouldn't make more sense to add organization as a sub-case for logo uploading (using a flag or a sub path)?

(*) I'm not saying we have to, I'm just exploring the domain.

@AleDore
Copy link
Contributor Author

AleDore commented Oct 26, 2020

I'm thinking about api design and keep our interface in good shape.

I see we introduced the /organizations sub path for our endpoints. This let me think we now have a new concept, Organization, and it might make sense to have concept-specific functionalities such as getOrganization, createOrganization, etc (*).
Is it the case? if so, I'm fine with the decision of organising endpoints like that. Otherwise, wouldn't make more sense to add organization as a sub-case for logo uploading (using a flag or a sub path)?

(*) I'm not saying we have to, I'm just exploring the domain.

It's a good point. I've used /organizations because potentially it's completely different from a service. An organization can create 1 or more service/s, but I agree with your point of view cc: @gunzip @francescopersico

@gunzip
Copy link
Contributor

gunzip commented Oct 26, 2020

there's some long term plan to have organizations as modelled entities so it's ok to have such an endpoint

Copy link
Contributor

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit e25d27c into master Oct 27, 2020
@AleDore AleDore deleted the 175395536_upload_organization_logo branch October 27, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants