Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175434645] Allow users to abort a DELETE request #113

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Oct 28, 2020

With this PR we introduce a dedicated endpoint for the app to abort a previous delete request from the user.

We decided to serve a dedicate endpoint because, If we let the user free about the status sto provide, we should have checked for every possible transitions. Moreover, ABORTED status really makes sense only for DELETE requests, as DOWNLOADs are elaborated as the come.

coauthored by @debiff

@balanza balanza requested review from gunzip, debiff, AleDore and Undermaken and removed request for Undermaken October 28, 2020 18:27
@balanza balanza self-assigned this Oct 28, 2020
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Oct 28, 2020

Affected stories

  • 🌟 #175434645: Come CIT voglio poter annullare la richiesta di cancellazione del profilo tramite app

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #113 into master will decrease coverage by 0.00%.
The diff coverage is 84.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   84.46%   84.46%   -0.01%     
==========================================
  Files          25       26       +1     
  Lines         734      766      +32     
  Branches       79       79              
==========================================
+ Hits          620      647      +27     
- Misses        109      114       +5     
  Partials        5        5              
Impacted Files Coverage Δ
AbortUserDataProcessing/handler.ts 84.37% <84.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bc4cf...9d2e313. Read the comment docs.

@balanza balanza merged commit 6c7a879 into master Oct 30, 2020
@balanza balanza deleted the 175434645-abort-delete-userdataprocessing branch October 30, 2020 08:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants