Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175126219] Healthcheck step in pipeline #117

Merged
merged 4 commits into from
Nov 27, 2020

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Nov 24, 2020

This PR introduces an healthcheck step just before promoting the staging slot to production.

Behaviour

  • deploy application to Staging slot
  • perform an http request against /info of the staging slot
  • if the request is ok (code == 200)
    • switch slot with production
  • else
    • abort the pipeline

Implementation

The implementation relies on this common template. The important concept is the http request is performed by a separate container which needs some configuration, please refer to the template repository for further info.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Nov 24, 2020

Affected stories

  • ⚙️ #175126219: Configurare l'healthcheck sulle pipeline dei deploy

Generated by 🚫 dangerJS

@gunzip
Copy link
Contributor

gunzip commented Nov 24, 2020

dependes on #116

Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that #116 is merged, do we need to disable autoswap in infra to merge & deploy this one?

azure-pipelines.yml Outdated Show resolved Hide resolved
@gunzip gunzip marked this pull request as ready for review November 27, 2020 22:08
@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #117 (47cc900) into master (84013f1) will decrease coverage by 2.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   84.33%   82.25%   -2.09%     
==========================================
  Files          26       28       +2     
  Lines         766      817      +51     
  Branches       80       82       +2     
==========================================
+ Hits          646      672      +26     
- Misses        115      140      +25     
  Partials        5        5              
Impacted Files Coverage Δ
Info/handler.ts 83.33% <0.00%> (ø)
utils/healthcheck.ts 41.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84013f1...47cc900. Read the comment docs.

azure-pipelines.yml Outdated Show resolved Hide resolved
@gunzip gunzip merged commit 30eafc9 into master Nov 27, 2020
@gunzip gunzip deleted the 175126219-healthcheck-pipeline branch November 27, 2020 22:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants