Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-84] Change strict configuration to true #157

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fabriziopapi
Copy link
Contributor

Set the stirct configuration to true.
Fixed the compilation errors caused by the new settings.
Some handlers are implemeted with an imperative paradigm: those code parts have not be refactored with a functional one.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

New dependencies added: @types/node-fetch.

@types/node-fetch

Author: Unknown

Description: TypeScript definitions for node-fetch

Homepage: http://npmjs.com/package/@types/node-fetch

Createdover 4 years ago
Last Updated6 days ago
LicenseMIT
Maintainers1
Releases36
Direct Dependencies@types/node and form-data
README

Installation

npm install --save @types/node-fetch

Summary

This package contains type definitions for node-fetch (https://github.com/bitinn/node-fetch).

Details

Files were exported from https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node-fetch.

Additional Details

Credits

These definitions were written by Torsten Werner, Niklas Lindgren, Vinay Bedre, Antonio Román, Andrew Leedham, Jason Li, Steve Faulkner, ExE Boss, Alex Savin, Alexis Tyler, and Jakub Kisielewski.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #157 (8220771) into master (ff1aabe) will decrease coverage by 0.63%.
The diff coverage is 85.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
- Coverage   82.25%   81.61%   -0.64%     
==========================================
  Files          28       29       +1     
  Lines         817      865      +48     
  Branches       82       82              
==========================================
+ Hits          672      706      +34     
- Misses        140      155      +15     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
utils/user_data_processings.ts 100.00% <ø> (ø)
utils/appinsights.ts 84.61% <50.00%> (-5.39%) ⬇️
utils/config.ts 73.68% <50.00%> (-7.57%) ⬇️
UpsertedProfileOrchestrator/handler.ts 73.13% <74.54%> (-6.18%) ⬇️
HandleNHNotificationCallActivity/handler.ts 90.00% <75.00%> (+0.41%) ⬆️
StartEmailValidationProcess/orchestrators.ts 78.57% <78.57%> (ø)
StartEmailValidationProcess/handler.ts 81.39% <86.66%> (-0.43%) ⬇️
AbortUserDataProcessing/handler.ts 84.37% <100.00%> (ø)
CreateProfile/handler.ts 84.21% <100.00%> (ø)
CreateValidationTokenActivity/handler.ts 84.84% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a35d9f...8220771. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants