Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IP-283] Set isEmailEnabled default to false #172

Merged
merged 8 commits into from
Jul 2, 2021
Merged

[#IP-283] Set isEmailEnabled default to false #172

merged 8 commits into from
Jul 2, 2021

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Jul 1, 2021

List of Changes

  • Set isEmailEnabled to false while creating new profiles

Motivation and Context

We want that a citizen has email notification deactivated in the default behavior after his registration through IO App.

How Has This Been Tested?

It has been tested by performing:

  • yarn lint
  • yarn test

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

balanza
balanza approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@balanza balanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can we merge and go prod, or should we wait?

@AleDore
Copy link
Contributor Author

AleDore commented Jul 2, 2021

LGTM

Can we merge and go prod, or should we wait?

We must wait I guess. Am I wrong @BurnedMarshal ?

BurnedMarshal
BurnedMarshal approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit 25ae8c0 into master Jul 2, 2021
@AleDore AleDore deleted the IP-283_set_is_email_enabled_default branch July 2, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@balanza balanza balanza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AleDore @pagopa-github-bot @balanza @BurnedMarshal