[#IP-284] add timestamp check on profile for is_email_enabled #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleDore
changed the title
Example of PR titles that include pivotal stories:
Generated by 🚫 dangerJS |
BurnedMarshal
requested changes
Jul 2, 2021
GetProfile/handler.ts
Outdated
| @@ -21,6 +21,7 @@ import { | |||
| } from "@pagopa/ts-commons/lib/responses"; | |||
| import { FiscalCode } from "@pagopa/ts-commons/lib/strings"; | |||
|
|
|||
| import * as date_fns from "date-fns"; | |||
There was a problem hiding this comment.
What if we import only isBefore method?
Suggested change
| import * as date_fns from "date-fns"; | |
| import { isBefore } from "date-fns"; |
| @@ -76,6 +77,8 @@ export const IConfig = t.intersection([ | |||
| SPID_LOGS_PUBLIC_KEY: NonEmptyString, | |||
| SUBSCRIPTIONS_FEED_TABLE: NonEmptyString, | |||
|
|
|||
| EMAIL_MODE_SWITCH_LIMIT_DATE: UTCISODateFromString, | |||
There was a problem hiding this comment.
Just a question. Is this variable required for some reason?
There was a problem hiding this comment.
Changed with default value in ee889ae
Co-authored-by: Daniele Manni <BurnedMarshal@users.noreply.github.com>
BurnedMarshal
requested changes
Jul 2, 2021
utils/config.ts
Outdated
| // No need to re-evaluate this object for each call | ||
| const errorOrConfig: t.Validation<IConfig> = IConfig.decode({ | ||
| ...process.env, | ||
| EMAIL_MODE_SWITCH_LIMIT_DATE: fromNullableE( |
There was a problem hiding this comment.
This value should be a string because here we apply the decoder IConfig and
UTCISODateFromString requires a string as input.
BurnedMarshal
requested changes
Jul 2, 2021
utils/config.ts
Outdated
Comment on lines
101
to
109
| EMAIL_MODE_SWITCH_LIMIT_DATE: fromNullableE( | ||
| DEFAULT_EMAIL_MODE_SWITCH_LIMIT_DATE | ||
| )(process.env.EMAIL_MODE_SWITCH_LIMIT_DATE) | ||
| .chain(_ => | ||
| UTCISODateFromString.decode(_).mapLeft( | ||
| () => DEFAULT_EMAIL_MODE_SWITCH_LIMIT_DATE | ||
| ) | ||
| ) | ||
| .fold(_ => new Date(_), identity), |
There was a problem hiding this comment.
Suggested change
| EMAIL_MODE_SWITCH_LIMIT_DATE: fromNullableE( | |
| DEFAULT_EMAIL_MODE_SWITCH_LIMIT_DATE | |
| )(process.env.EMAIL_MODE_SWITCH_LIMIT_DATE) | |
| .chain(_ => | |
| UTCISODateFromString.decode(_).mapLeft( | |
| () => DEFAULT_EMAIL_MODE_SWITCH_LIMIT_DATE | |
| ) | |
| ) | |
| .fold(_ => new Date(_), identity), | |
| EMAIL_MODE_SWITCH_LIMIT_DATE: fromNullable(process.env.EMAIL_MODE_SWITCH_LIMIT_DATE) | |
| .getOrElse(DEFAULT_EMAIL_MODE_SWITCH_LIMIT_DATE), |
AleDore
deleted the
IP-284_add_timestamp_check_on_profile_for_is_email_enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
EMAIL_MODE_SWITCH_LIMIT_DATEin config propertiesGetProfilereturns isEmailEnabled set to false if profile timestamp is before a specific limit date (see previous bullet), otherwise return the value stored on cosmosdbStoreSpidLogsfunction for better unit testingMotivation and Context
We want that a citizen with an old profile, or even a profile that was upserted before the release limit date, has email notification turned off for default
How Has This Been Tested?
It has been tested by performing:
Types of changes