Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-408] Error tracking for enrichment (plus small fix) #220

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

michaeldisaro
Copy link
Contributor

@michaeldisaro michaeldisaro commented Oct 6, 2021

List of Changes

  • added custom event tracking for enrichment errors
  • added function logging for enrichment errors
  • fixed the result for getVisibleServices by removing page_size.

Motivation and Context

We need to track enrichment errors to be able to check why it is failing.

How Has This Been Tested?

  • yarn build
  • yarn test
  • yarn lint
  • postman tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@michaeldisaro michaeldisaro marked this pull request as ready for review October 6, 2021 16:08
@michaeldisaro michaeldisaro requested a review from a team as a code owner October 6, 2021 16:08
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the context log outcome, please add some checks to test the error strings.

utils/__tests__/messages.test.ts Outdated Show resolved Hide resolved
utils/__tests__/messages.test.ts Outdated Show resolved Hide resolved
utils/tracking.ts Outdated Show resolved Hide resolved
utils/messages.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeldisaro michaeldisaro merged commit 5149745 into master Oct 7, 2021
@michaeldisaro michaeldisaro deleted the ip-362_error_logging branch October 7, 2021 11:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants