Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use reference to package SDK #274

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

StefanoDoc
Copy link

List of Changes

  1. imported io-backend-session package
  2. removed script that generated definition from specification
  3. switched to package sdk

Motivation and Context

to speed up build time

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@StefanoDoc StefanoDoc requested a review from a team as a code owner January 5, 2023 11:36
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jan 5, 2023

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

@pagopa/io-backend-sdk

Author: Unknown

Description: Generated SDK for @pagopa/io-backend. IO app and web backend

Homepage: http://npmjs.com/package/@pagopa/io-backend-sdk

Createdalmost 2 years ago
Last Updated9 months ago
LicenseISC
Maintainers4
Releases2
Direct Dependenciesfp-ts, io-ts and italia-ts-commons
README

ERROR: No README data found!

New dependencies added: @pagopa/io-backend-sdk.

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

package.json Outdated
@@ -59,6 +56,7 @@
"@azure/cosmos": "^3.17.1",
"@azure/storage-queue": "^12.4.0",
"@pagopa/express-azure-functions": "^2.0.0",
"@pagopa/io-backend-sdk": "^7.15.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use x as version, so we always follow latest version

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment on lines +762 to +769
"@pagopa/io-backend-sdk@x":
version "7.15.5"
resolved "https://registry.yarnpkg.com/@pagopa/io-backend-sdk/-/io-backend-sdk-7.15.5.tgz#a0246c1f6147312c4e8780b2c1d7ca48f297c1c9"
integrity sha512-Dj/L6ta24jyxmCcca5kdFRo1+hd9LNfjI7fD6c6Erax5h/LwQe8qt/VKvX0Ps9UKr9AIbZHR3hDSnun1Q+Qagg==
dependencies:
fp-ts "1.17.4"
io-ts "1.8.5"
italia-ts-commons "^5.1.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We expect version 9.x to be installed, but there is actually a bug on publication such as the package is back to 7.x. This implies it uses fp-ts@1.x and italia-ts-commons, which are deprecated in our applications.

So we must wait for the new sdk package to be published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants