Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#ICC-322] Replace danger with a github action #276

Merged
merged 8 commits into from
Feb 3, 2023
Merged

[#ICC-322] Replace danger with a github action #276

merged 8 commits into from
Feb 3, 2023

Conversation

fabriziopapi
Copy link
Contributor

List of Changes

see commit history

Motivation and Context

Danger is annoying to mantain due to token management.
We want to globally raplace it with a github action.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@fabriziopapi fabriziopapi requested a review from a team as a code owner January 30, 2023 19:04
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue ICC-322

@fabriziopapi fabriziopapi mentioned this pull request Jan 31, 2023
Merged
6 tasks
@fabriziopapi @pasqualedevita
Update .github/workflows/pr-title-linter-and-linker.yaml
9ddfbf7 
Co-authored-by: Pasquale De Vita <59291437+pasqualedevita@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gquadrati
gquadrati approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AleDore AleDore merged commit afeaa21 into master Feb 3, 2023
@AleDore AleDore deleted the ICC-322--replace-danger branch February 3, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal was automatically assigned from pagopa/io-backend-contributors

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo was automatically assigned from pagopa/io-backend-contributors

@AleDore AleDore Awaiting requested review from AleDore

@Garma00 Garma00 Awaiting requested review from Garma00

@pasqualedevita pasqualedevita Awaiting requested review from pasqualedevita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopapi @pasqualedevita @Garma00 @gquadrati @AleDore