Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPID-1050, IOPID-1051] Add unique e-mail enforcement to UpdateProfile #290

Merged
merged 18 commits into from
Dec 19, 2023
Merged

[IOPID-1050, IOPID-1051] Add unique e-mail enforcement to UpdateProfile #290

merged 18 commits into from
Dec 19, 2023

Conversation

lucacavallaro
Copy link
Member

List of Changes

UpdateProfile now returns a HTTP 412 error when an when a user tries to change their email address with one validated by another user

Motivation and Context

How Has This Been Tested?

unit test + io-mock

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to Jira issues:
- Link to IOPID-1050
- Link to IOPID-1051

@lucacavallaro lucacavallaro mentioned this pull request Dec 18, 2023
Merged
6 tasks
arcogabbo
arcogabbo reviewed Dec 18, 2023
View reviewed changes
openapi/index.yaml Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

12.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gquadrati gquadrati marked this pull request as ready for review December 19, 2023 08:42
@gquadrati gquadrati requested a review from a team as a code owner December 19, 2023 08:43
BurnedMarshal
BurnedMarshal approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit c1d8b8f into master Dec 19, 2023
3 of 4 checks passed
@gquadrati gquadrati deleted the IOPID-1050-1051-unique-email-enforcement-update-profile branch December 19, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo left review comments

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@giamma1295 giamma1295 Awaiting requested review from giamma1295 giamma1295 was automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacavallaro @BurnedMarshal @arcogabbo @gquadrati