[#IOPID-1449] enable strict=true on typescript config
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-1449 |
|
/azp run |
|
No pipelines are associated with this pull request. |
arcogabbo
approved these changes
Mar 4, 2024
gquadrati
reviewed
Mar 4, 2024
| // NOTE: if the following check is changed make sure to pass add the name field | ||
| // to CreateProfile method which also calls this orchestrator | ||
| if (isProfileEmailChanged) { | ||
| if (isProfileEmailChanged && newProfile.email) { |
There was a problem hiding this comment.
Although it's unlikely, if the email changes to undefined, could we raise an event?
There was a problem hiding this comment.
Do you mean just for monitoring?
There was a problem hiding this comment.
Yes, just to ensure it never happen.
…o avoid Mixed type incompatibility.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Code refactory after enabling the
strict=trueoption intsconfig.Motivation and Context
Having a
strict=falseoption for Typescript transpiling can generate application and logic errors to handle properlyundefinedornullproperties. This setting helps to prevent bugs in production.How Has This Been Tested?
buildand unit testScreenshots (if appropriate):
Types of changes