[#170133263] Create ValidationTokens storage table if not exists #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 16 16
Lines 469 469
Branches 45 45
=======================================
Hits 383 383
Misses 86 86 |
gunzip
reviewed
Dec 5, 2019
| @@ -27,6 +27,10 @@ const hashCreator = (value: string) => | |||
| .update(value) | |||
| .digest("hex"); | |||
|
|
|||
| // When the function starts, attempt to create the table if it does not exist | |||
| // Note that we cannot log anything just yet since we don't have a Context | |||
| tableService.createTableIfNotExists(VALIDATION_TOKEN_TABLE_NAME, () => 0); | |||
There was a problem hiding this comment.
this is an async operation, the table exists inside the () => 0 (the following code may fail)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.