Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#172308410] refactor StoreSpidLogs and track with Application Insights #62

Merged
merged 7 commits into from
Apr 14, 2020

Conversation

gunzip
Copy link
Contributor

@gunzip gunzip commented Apr 14, 2020

  • refactor StoreSpidLogs from async method to use context.done instead
  • upgraded some packages (needed to integrate application insights initialization)
  • fixed some tests to work with newer models
  • added application insights initializer

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   81.80%   82.07%   +0.27%     
==========================================
  Files          20       20              
  Lines         566      569       +3     
  Branches       54       55       +1     
==========================================
+ Hits          463      467       +4     
+ Misses        103      102       -1     
Impacted Files Coverage Δ
GetUserDataProcessing/handler.ts 72.72% <ø> (ø)
StartEmailValidationProcess/handler.ts 81.81% <ø> (+3.03%) ⬆️
UpsertUserDataProcessing/handler.ts 81.39% <ø> (ø)
StoreSpidLogs/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c516054...4c0b118. Read the comment docs.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Apr 14, 2020

Affected stories

  • ⚙️ #172308410: Abilitare il tracking delle dipendenze (es. cosmosdb)

New dependencies added: applicationinsights.

applicationinsights

Author: Unknown

Description: Microsoft Application Insights module for Node.js

Homepage: https://github.com/Microsoft/ApplicationInsights-node.js#readme

Createdover 5 years ago
Last Updated5 days ago
LicenseMIT
Maintainers1
Releases69
Direct Dependenciescls-hooked, continuation-local-storage, diagnostic-channel and diagnostic-channel-publishers
Keywordsexception monitoring, request monitoring, performance monitoring, application insights, microsoft, azure, cloud, tracing, telemetry, analytics and apm
This README is too long to show.

Generated by 🚫 dangerJS

@gunzip gunzip changed the title upgrade functions package [#172308410] refactor StoreSpidLogs and track with Application Insights Apr 14, 2020
@gunzip gunzip requested a review from cloudify April 14, 2020 12:33
@gunzip gunzip merged commit 97f0646 into master Apr 14, 2020
@gunzip gunzip deleted the 172308410-ai-tracking branch April 14, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants