Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#173921255] Fix conflict case on UserDataProcessing upsert #98

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Jul 23, 2020

The code didn't considered the FAILED status. I reversed the check to look for active statuses (PENDING and WIP) and return conflict in such cases.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #98 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   84.74%   84.67%   -0.08%     
==========================================
  Files          26       26              
  Lines         767      796      +29     
  Branches       75       79       +4     
==========================================
+ Hits          650      674      +24     
- Misses        113      118       +5     
  Partials        4        4              
Impacted Files Coverage Δ
UpsertUserDataProcessing/handler.ts 87.01% <100.00%> (-2.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec8b90...bbb6f9e. Read the comment docs.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Jul 23, 2020

Affected stories

  • 🌟 #173921255: Come CIT voglio poter avviare una procedura di DOWNLOAD/DELETE se la precedente è fallita o abortita

Generated by 🚫 dangerJS

@balanza balanza force-pushed the 173921255-fix-udp-conflict branch from fc8188f to bbb6f9e Compare July 23, 2020 12:14
@gunzip gunzip merged commit 88c5c15 into master Jul 23, 2020
@gunzip gunzip deleted the 173921255-fix-udp-conflict branch July 23, 2020 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants