Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCOM-556] Add has_precondition flag to ThirdPartyData #336

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Sep 26, 2023

List of Changes

Motivation and Context

Third party should be able to specify preconditions during the CreateMessage

How Has This Been Tested?

Unit test.

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner September 26, 2023 09:23
@Garma00 Garma00 requested review from Krusty93 and iwoak September 26, 2023 09:23
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-556

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but before merging and releasing let's check if this new defintion breaks anything in io-functions-services and in other places.

@Garma00
Copy link
Contributor Author

Garma00 commented Sep 28, 2023

LGTM, but before merging and releasing let's check if this new defintion breaks anything in io-functions-services and in other places.

Tested locally with io-backend and io-functions-services everything works fine

@Garma00 Garma00 merged commit ec20913 into master Sep 28, 2023
4 checks passed
@Garma00 Garma00 deleted the IOCOM-556-add-hasprecondition-flag branch September 28, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants