Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1111] Add async iterable task utilities + tests #343

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[#IOPID-1111] Add async iterable task utilities + tests #343

merged 2 commits into from
Jan 4, 2024

Conversation

gquadrati
Copy link
Contributor

List of Changes

  • add new async_iterable_task.ts file, already tested on fn-app-messages and io-backend
  • add tests

Motivation and Context

Refactor to reduce code duplication

How Has This Been Tested?

Unit tests

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1111

@gquadrati gquadrati marked this pull request as ready for review November 14, 2023 10:55
@gquadrati gquadrati requested a review from a team as a code owner November 14, 2023 10:55
@gquadrati gquadrati mentioned this pull request Nov 23, 2023
Merged
6 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@gquadrati gquadrati merged commit ee43760 into master Jan 4, 2024
5 checks passed
@gquadrati gquadrati deleted the IOPID-1111 branch January 4, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@michaeldisaro michaeldisaro Awaiting requested review from michaeldisaro michaeldisaro is a code owner automatically assigned from pagopa/io-backend-contributors

@pagopa-github-bot pagopa-github-bot Awaiting requested review from pagopa-github-bot pagopa-github-bot is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @BurnedMarshal