Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-704] Add has_remote_content flag #347

Merged
merged 1 commit into from
Nov 28, 2023
Merged

[#IOCOM-704] Add has_remote_content flag #347

merged 1 commit into from
Nov 28, 2023

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Nov 27, 2023

List of Changes

Motivation and Context

We need a flag to know wether there is a remote content or not.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner November 27, 2023 14:45
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-704

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

michaeldisaro
michaeldisaro approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@michaeldisaro michaeldisaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Garma00 Garma00 merged commit ff2ae49 into master Nov 28, 2023
6 checks passed
@Garma00 Garma00 deleted the add-has_remote_content branch November 28, 2023 11:33
acuiuli

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuiuli acuiuli acuiuli left review comments

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@grausof grausof Awaiting requested review from grausof grausof is a code owner automatically assigned from pagopa/io-backend-contributors

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garma00 @michaeldisaro @acuiuli