Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOCOM-729] Added new RemoteContentConfiguration model and tests #351

Merged
merged 6 commits into from
Dec 12, 2023
Merged

[#IOCOM-729] Added new RemoteContentConfiguration model and tests #351

merged 6 commits into from
Dec 12, 2023

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Added new model
Added tests

Motivation and Context

We need a new model to retrieve Remote Content Configuration

How Has This Been Tested?

yarn install
yarn lint
yarn build
yarn test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@michaeldisaro michaeldisaro requested a review from a team as a code owner December 12, 2023 13:59
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-729

acuiuli
acuiuli approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@michaeldisaro michaeldisaro merged commit efffc0b into master Dec 12, 2023
5 checks passed
@michaeldisaro michaeldisaro deleted the iocom-729 branch December 12, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garma00 Garma00 Garma00 left review comments

@acuiuli acuiuli acuiuli approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@giamma1295 giamma1295 Awaiting requested review from giamma1295 giamma1295 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldisaro @acuiuli @Garma00