Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPID-1245] Remove fiscal code filter to avoid full table scan #352

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[IOPID-1245] Remove fiscal code filter to avoid full table scan #352

merged 1 commit into from
Dec 13, 2023

Conversation

lucacavallaro
Copy link
Member

@lucacavallaro lucacavallaro commented Dec 12, 2023 •
edited
Loading

List of Changes

  1. removed the possibility to filter the uniqueEmails table by its row key

Motivation and Context

filter a table for a row key is an expensive operation, that it is not justified by practical reasons

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lucacavallaro lucacavallaro requested a review from a team as a code owner December 12, 2023 15:08
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1245

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucacavallaro lucacavallaro requested review from gquadrati and removed request for Krusty93 and Garma00 December 12, 2023 15:09
@lucacavallaro lucacavallaro merged commit b825504 into master Dec 13, 2023
6 checks passed
@lucacavallaro lucacavallaro deleted the IOPID-1245-remove-fiscal-code-filter branch December 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacavallaro @gquadrati