Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-1197] Add get method to table storage model #354

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[#IOPID-1197] Add get method to table storage model #354

merged 1 commit into from
Jan 9, 2024

Conversation

silvicir
Copy link
Contributor

@silvicir silvicir commented Jan 9, 2024

List of Changes

Added get method to IProfileEmailReader interface and to the DataTableProfileEmailsRepository implementation

Motivation and Context

This method is needed in the OnProfileUpdate function to get the entity from (partitionKey, rowKey)

How Has This Been Tested?

Through unit tests

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@silvicir silvicir requested a review from a team as a code owner January 9, 2024 10:27
@silvicir silvicir requested review from rodoviti and acuiuli January 9, 2024 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1197

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucacavallaro lucacavallaro merged commit 44c9ccb into master Jan 9, 2024
5 checks passed
@lucacavallaro lucacavallaro deleted the IOPID-1197-update-table-storage-model branch January 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacavallaro lucacavallaro lucacavallaro approved these changes

@rodoviti rodoviti Awaiting requested review from rodoviti rodoviti is a code owner automatically assigned from pagopa/io-backend-contributors

@acuiuli acuiuli Awaiting requested review from acuiuli acuiuli is a code owner automatically assigned from pagopa/io-backend-contributors

@gquadrati gquadrati Awaiting requested review from gquadrati

@arcogabbo arcogabbo Awaiting requested review from arcogabbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silvicir @lucacavallaro