Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uee): [IOPID-1325] add DataTableProfileEmailsRepository error cause #355

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat(uee): [IOPID-1325] add DataTableProfileEmailsRepository error cause #355

merged 4 commits into from
Jan 11, 2024

Conversation

lucacavallaro
Copy link
Member

List of Changes

  1. add cause field on error throws by DataTableProfileEmailsRepository's delete and insert
  2. remove get method

Motivation and Context

with this change we can achieve better error handling

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lucacavallaro lucacavallaro requested a review from a team as a code owner January 11, 2024 11:22
@github-actions GitHub Actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-1325

@lucacavallaro
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

gquadrati
gquadrati approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the two comments

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lucacavallaro lucacavallaro merged commit 70abae2 into master Jan 11, 2024
5 checks passed
@lucacavallaro lucacavallaro deleted the IOPID-1325-add-error-cause branch January 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvicir silvicir silvicir approved these changes

@gquadrati gquadrati gquadrati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacavallaro @gquadrati @silvicir