Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCOM-917] Add new RC model #357

Merged
merged 9 commits into from
Jan 24, 2024
Merged

[#IOCOM-917] Add new RC model #357

merged 9 commits into from
Jan 24, 2024

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Jan 22, 2024

List of Changes

Motivation and Context

We need another model for RC, the old one is deprecated from now on and it will be removed asap.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner January 22, 2024 14:20
Copy link

github-actions bot commented Jan 22, 2024

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-917

@Garma00 Garma00 changed the title [I#IOCOM-917] Add new RC model [#IOCOM-917] Add new RC model Jan 22, 2024
Copy link
Contributor

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/models/remote_content.ts Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Garma00 Garma00 merged commit f154135 into master Jan 24, 2024
5 checks passed
@Garma00 Garma00 deleted the IOCOM-917 branch January 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants