[#DEVEX-60] Update fp-ts and io-ts peerDeps #370
Conversation
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEVEX-60 |
BurnedMarshal
requested review from
balanza and
lucacavallaro
and removed request for
Garma00 and
silvicir
package.json
Outdated
| "applicationinsights": "^1.8.10", | ||
| "azure-storage": "^2.10.5", | ||
| "cidr-matcher": "^2.1.1", | ||
| "fp-ts": "^2.10.5", | ||
| "fp-ts": "2.16.2", |
There was a problem hiding this comment.
question: We're referencing a specific version rather than a pattern. Is that deliberate or a typo?
There was a problem hiding this comment.
It's deliberate. The last upgrade of this library and the combination with the io-ts are incompatible. To avoid compilation error you must have the right combo between the two libs. I've choose to lock the libs version.
There was a problem hiding this comment.
Ok, great. Just for future reference, do you have any issue/article to link, if any?
There was a problem hiding this comment.
The commit 4aa6c4e use fp-ts and io-ts as peer dependencies. This allow to resolve conflicts at the project level. Now the libs version are not locked anymore.
|
BurnedMarshal
changed the title
|
/azp run |
|
No pipelines are associated with this pull request. |
List of Changes
Upgrade
fp-tsandio-tsto the lastest available version.Updated other libs in dependencies.
Motivation and Context
To complete an integration into a monorepo, is required that
@pagopa/ts-commonsand@pagopa/io-functions-commonsuse the same version of the fp-ts ecosystem libraries. Declaring the two libraries aspeerDependenciesallow the main project that useio-functions-commonsto command how lib version should be used.How Has This Been Tested?
not tested
Screenshots (if appropriate):
Types of changes