[DEVEX-106] Fix proposal #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
requested review from
michaeldisaro,
pasqualedevita and
lucacavallaro
and removed request for
a team,
michaeldisaro and
pasqualedevita
Jira Pull Request LinkThis Pull Request refers to the following Jira issue DEVEX-106 |
|
lucacavallaro
approved these changes
Mar 28, 2024
| Record<PartitionKey, string | number> | ||
| ? PartitionKey extends ModelIdKey // partition key === model id means no partition key is provided | ||
| ? readonly [string] | ||
| : readonly [string, string | number] |
There was a problem hiding this comment.
maybe we should also support boolean (?)
Suggested change
| : readonly [string, string | number] | |
| : readonly [string, string | number | boolean] |
There was a problem hiding this comment.
Technically yes. What boolean partition key you imagine to use?
There was a problem hiding this comment.
I can't imagine any! I was just wondering to "adhere" to the PrimaryKey type of @azure/cosmos which puts it among the supported scalars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a fix on #371
The
DocumentSearchKeytype ensures we query database object by fields whose type isstring(for model id) orstring | number(for partition key)