Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FF_OPT_IN_EMAIL_ENABLED Feature Flag #138

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Jul 5, 2021

In order to enable opt in email we need a Feature flag that could drive our beta phase without impacting default behaviour before the release date.

List of Changes

  • Add FF_OPT_IN_EMAIL_ENABLED env variable
  • Update StoreMessageContentActivity
  • Add Unit test based on new env variable

Motivation and Context

This PR allows us to enable opt in email at the right moment

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this? Is needed a rebase first.

@BurnedMarshal BurnedMarshal force-pushed the add_ff_opt_in_email_enabled branch from e9cce58 to daf59ff Compare July 8, 2021 13:16
@BurnedMarshal BurnedMarshal merged commit 14c8037 into master Jul 8, 2021
@BurnedMarshal BurnedMarshal deleted the add_ff_opt_in_email_enabled branch July 8, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants