Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-297] Move OPT_OUT_EMAIL_SWITCH_DATE to Timestamp format #140

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Jul 5, 2021

In order to make Date env variable compliant to App service issue we must to parse Date with Timestamp format

List of Changes

  • Move OPT_OUT_EMAIL_SWITCH_DATE format to Timestamp
  • Upgrade @pagopa/ts-commons package

Motivation and Context

This PR allows us to use Timestamp format on Date env variable

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just a question. We have now (see with yarn why) 3 versions of @pagopa/ts-commons, could be a problem in production?

@AleDore
Copy link
Contributor Author

AleDore commented Jul 6, 2021

LGTM.
Just a question. We have now (see with yarn why) 3 versions of @pagopa/ts-commons, could be a problem in production?

Nope, there are only minor changes (non breaking) that could coexist ;)

@AleDore AleDore merged commit b8c2530 into master Jul 6, 2021
@AleDore AleDore deleted the IP-297_move_to_timestamp_format_for_opt_out_email_switch_date branch July 6, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants