-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#IP-184] Add payee management to Send Message #158
Conversation
Example of PR titles that include pivotal stories:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, apart knowing why node downgrade is necessary.
@@ -1 +1 @@ | |||
14.17.5 | |||
14.16.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this is the version supported by Azure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagined that. 👍
It's two days that danger is failing with that error, should we worry about it? |
We have to refactor danger plugin with Jira integration pagopa/danger-plugin-digitalcitizenship#114 |
I think we also have to remove this "pivotal" warning. |
List of Changes
io-functions-commons
ref with new Message model and Payment Data definition@pagopa/ts-commons
with new version that allows to accept infinite middlewaresApiMessageWriteWithPayee
can send messages with defined payeeStoreMessageContentActivity
Motivation and Context
This PR allows to Send Payment messages with specific payee only for users (and services) that are authorized to.
In addition we check over
payment_data
if present and overridepayee
value with default sender fiscal_code value for other users/services.How Has This Been Tested?
unit test
Io-mock
Screenshots (if appropriate):
Types of changes
Checklist: