[#IC-349] Add fiscalCode to message_status in CreateMessage process #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of PR titles that include pivotal stories:
|
fabriziopapi
requested review from
BurnedMarshal,
domenicoventriglia and
AleDore
AleDore
reviewed
Mar 15, 2022
AleDore
reviewed
Mar 16, 2022
BurnedMarshal
requested changes
Mar 16, 2022
BurnedMarshal
requested changes
Mar 16, 2022
Co-authored-by: Daniele Manni <BurnedMarshal@users.noreply.github.com>
Co-authored-by: Daniele Manni <BurnedMarshal@users.noreply.github.com>
(-) Removed useless decode (+) replaced toUnion with getOrElse
(+) moved aMessageStatus to mock to reduce duplication
BurnedMarshal
approved these changes
Mar 17, 2022
Co-authored-by: Daniele Manni <BurnedMarshal@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
fabriziopapi
deleted the
IC-349--add-fiscalcode-to-messagestatus-in-createmessage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the message_status collection do not contain the message owner fiscalCode. This will reduce the performace of querying the message from its status (with messageId alone, the query on messages collection is 8 times more RU consuming).
List of Changes
add fiscalCode on create message process
add fiscalCode on failed process
Motivation and Context
We need to retrieve the message from its status in order to keep aligned the view used by paginated list messages and search messages operations.
How Has This Been Tested?
unit tests
Screenshots (if appropriate):
Types of changes
Checklist: