Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#ICC-68] Update submitMessage content introducing ThirdPartyData #207

Merged
merged 4 commits into from
May 25, 2022
Merged

[#ICC-68] Update submitMessage content introducing ThirdPartyData #207

merged 4 commits into from
May 25, 2022

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented May 19, 2022 •
edited
Loading

This PR depends on pagopa/io-functions-commons#271

List of Changes

  • Update index.yaml openapi for allowing submitMessage to receive third_party_data property
  • merged #ICC-86: add auth middleware

Motivation and Context

Introduction of a generic management for handling third party message details

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented May 19, 2022 •
edited
Loading

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 87ad45d

@gquadrati gquadrati marked this pull request as ready for review May 19, 2022 13:37
@gquadrati gquadrati requested a review from a team as a code owner May 19, 2022 13:37
@gquadrati gquadrati requested review from arcogabbo and Garma00 May 19, 2022 13:37
@dpulls
Copy link

dpulls bot commented May 23, 2022

🎉 All dependencies have been resolved !

@gquadrati gquadrati changed the title [#IC-68] Update submitMessage content introducing ThirdPartyData [#ICC-68] Update submitMessage content introducing ThirdPartyData May 23, 2022
@gquadrati gquadrati requested review from fabriziopapi and AleDore May 23, 2022 12:22
@AleDore @gquadrati
[#ICC-86] Add Third Party Middleware (#208)
87ad45d 
* Add Third Party Middleware check for specific group

* [#ICC-86] update ApiNewMessageWithContentOf

* [#ICC-86] add integration tests

Co-authored-by: gquadrati <greta.quadrati@pagopa.it>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AleDore AleDore merged commit 64fdefc into master May 25, 2022
@AleDore AleDore deleted the IC-68--update-openapi-send-message branch May 25, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopapi fabriziopapi fabriziopapi approved these changes

@AleDore AleDore AleDore approved these changes

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo is a code owner automatically assigned from pagopa/io-backend-contributors

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gquadrati @pagopa-github-bot @AleDore @fabriziopapi