[#168694799] Update specification for CreateMessage #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 5 5
Lines 332 332
Branches 43 43
=======================================
Hits 279 279
Misses 52 52
Partials 1 1 |
cloudify
suggested changes
Sep 23, 2019
openapi/index.yaml
Outdated
| $ref: "#/definitions/ProblemJson" | ||
| "/messages/{fiscal_code}": | ||
| post: | ||
| operationId: submitMessageforUserWithFiscalCode |
There was a problem hiding this comment.
this breaks backward compatibility, this operation name should not change (submitMessageforUser), the other one (new) should have a new name
There was a problem hiding this comment.
Exactly the reason why i asked if the operationId was used by the client generator. I Have fixed with the new commit.
Affected stories
Generated by 🚫 dangerJS |
cloudify
approved these changes
Sep 23, 2019
cloudify
deleted the
168694799-update-specification-for-createmessage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated with changes from #18