Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ICC-168] more self explanatory error messages #221

Merged
merged 7 commits into from
Aug 12, 2022
Merged

[ICC-168] more self explanatory error messages #221

merged 7 commits into from
Aug 12, 2022

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Aug 11, 2022

List of Changes

  • Updated ts-commons to 10.9.0
  • Updated io-function-commons to 25.6.2
  • Updated some error messages to be clearer
  • Added some integration tests
  • Added some unit tests

Motivation and Context

In order to have more self explanatory error messages i have updated some detail

How Has This Been Tested?

unit and integration test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Garma00 Garma00 requested a review from a team as a code owner August 11, 2022 10:29
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Aug 11, 2022 •
edited
Loading

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against eadbc48

gquadrati
gquadrati reviewed Aug 12, 2022
View reviewed changes
CreateMessage/handler.ts Outdated Show resolved Hide resolved
__integrations__/index.test.ts Outdated Show resolved Hide resolved
@Garma00 @gquadrati
Apply suggestions from code review
eadbc48 
Co-authored-by: Greta Quadrati <75862507+gquadrati@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Garma00 Garma00 merged commit 399fb07 into master Aug 12, 2022
@Garma00 Garma00 deleted the ICC-168 branch August 12, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopapi fabriziopapi fabriziopapi approved these changes

@gquadrati gquadrati gquadrati approved these changes

@michaeldisaro michaeldisaro Awaiting requested review from michaeldisaro michaeldisaro is a code owner automatically assigned from pagopa/io-backend-contributors

@LoFrance LoFrance Awaiting requested review from LoFrance LoFrance is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garma00 @pagopa-github-bot @gquadrati @fabriziopapi