Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPSC-81] Trace ApiKey existence on Service creation #224

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[#IOPSC-81] Trace ApiKey existence on Service creation #224

merged 1 commit into from
Sep 22, 2022

Conversation

balanza
Copy link
Contributor

@balanza balanza commented Sep 22, 2022 •
edited
Loading

List of Changes

  • add has_primary_key and has_secondary_key attribute on api.services.create tracing event
    `

Motivation and Context

We have feedback of Services created correctly but the payload does not contain the ApiKey. This PR introduces a traces so that we can have evidence of the bug

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@balanza balanza requested review from iwoak and LoFrance September 22, 2022 13:15
@balanza balanza requested a review from a team as a code owner September 22, 2022 13:15
@balanza balanza requested a review from arcogabbo September 22, 2022 13:15
@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against ed4617d

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@balanza balanza merged commit 9d9c3a8 into master Sep 22, 2022
@balanza balanza deleted the IOPSC-81-la-creazione-di-un-servizio-tramite-api-non-ritorna-le-api-key branch September 22, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoak iwoak Awaiting requested review from iwoak

@LoFrance LoFrance Awaiting requested review from LoFrance

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balanza @pagopa-github-bot