[ICC-201] Set ttl of message and message-status to 3 years for not registered users #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example of PR titles that include pivotal stories:
|
gquadrati
reviewed
Oct 28, 2022
AleDore
reviewed
Oct 31, 2022
gquadrati
requested changes
Oct 31, 2022
gquadrati
reviewed
Nov 4, 2022
gquadrati
requested changes
Nov 7, 2022
| @@ -531,6 +548,8 @@ describe("getprocessMessageHandler", () => { | |||
| TE.of(O.some(messageData)) | |||
| ); | |||
| const processMessageHandler = getProcessMessageHandler({ | |||
| TTL_FOR_USER_NOT_FOUND, | |||
| isUserForFeatureFlag, | |||
There was a problem hiding this comment.
Test this failing scenario without enabling FF, since we added a specific test right after for checking the new scenario.
Suggested change
| isUserForFeatureFlag, | |
| isUserForFeatureFlag: (_: FiscalCode) => false, |
gquadrati
requested changes
Nov 7, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
gquadrati
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
ttlto 3 years when user is not found;Motivation and Context
In order to remove messages sent to users not registered we want to set the
ttlto 3 years tomessageandmessage-status.How Has This Been Tested?
Unit test
Screenshots (if appropriate):
Types of changes
Checklist: