Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flag #231

Merged
merged 21 commits into from
Nov 30, 2022
Merged

Remove feature flag #231

merged 21 commits into from
Nov 30, 2022

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Nov 8, 2022

List of Changes

  • Remove feature flag references;

Motivation and Context

To clean up the code we want to remove the feature flag when it is no longer needed.

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Nov 8, 2022 •
edited
Loading

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 1ee9436

@Garma00 Garma00 marked this pull request as ready for review November 24, 2022 09:49
@Garma00 Garma00 requested a review from a team as a code owner November 24, 2022 09:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gquadrati
gquadrati approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ProcessMessage/__tests__/handler.test.ts
@@ -591,6 +586,7 @@ describe("getprocessMessageHandler", () => {

expect(messageStatusUpdaterParam).toEqual({
status: RejectedMessageStatusValueEnum.REJECTED,
ttl: O.isNone(profileResult) ? 94670856 : undefined, // we want ttl setted only in case the user does not exist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Garma00 Garma00 merged commit 73bff68 into master Nov 30, 2022
@Garma00 Garma00 deleted the remove-feature-flag branch November 30, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@arcogabbo arcogabbo Awaiting requested review from arcogabbo arcogabbo is a code owner automatically assigned from pagopa/io-backend-contributors

@LoFrance LoFrance Awaiting requested review from LoFrance LoFrance is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garma00 @pagopa-github-bot @gquadrati