Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error details to update message status ttl error #234

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Add error details to update message status ttl error #234

merged 2 commits into from
Nov 9, 2022

Conversation

fabriziopapi
Copy link
Contributor

Add error details to app insight event generated when a cosmos error is thrown by update ttl on verisoned model

List of Changes

see commit history

Motivation and Context

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@fabriziopapi fabriziopapi requested a review from a team as a code owner November 9, 2022 17:14
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Nov 9, 2022 •
edited
Loading

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 79e8ac8

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fabriziopapi fabriziopapi merged commit 519771f into master Nov 9, 2022
@fabriziopapi fabriziopapi deleted the add-error-details-to-message-status-update-ttl branch November 9, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleDore AleDore AleDore approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@domenicoventriglia domenicoventriglia Awaiting requested review from domenicoventriglia domenicoventriglia is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopapi @pagopa-github-bot @AleDore