Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOCIT-195] Use messageStatusUpdarter to set the ttl #237

Merged
merged 8 commits into from
Nov 23, 2022
Merged

[IOCIT-195] Use messageStatusUpdarter to set the ttl #237

merged 8 commits into from
Nov 23, 2022

Conversation

Garma00
Copy link
Contributor

@Garma00 Garma00 commented Nov 17, 2022

List of Changes

  • Update @pagopa/io-functions-commons;
  • Set the ttl during the upsert when the user does not exist;

Motivation and Context

We need to set the ttl directly when creating the entry of the message status in order to solve an issue with cosmos.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Nov 17, 2022 •
edited
Loading

Warnings
⚠️ Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS against 7735eef

@Garma00 Garma00 changed the title Iocit 195 [IOCIT-195] Use messageStatusUpdarter to set the ttl Nov 18, 2022
gquadrati
gquadrati requested changes Nov 21, 2022
View reviewed changes
ProcessMessage/handler.ts Outdated Show resolved Hide resolved
ProcessMessage/handler.ts Outdated Show resolved Hide resolved
ProcessMessage/handler.ts Outdated Show resolved Hide resolved
ProcessMessage/__tests__/handler.test.ts Outdated Show resolved Hide resolved
gquadrati
gquadrati approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than this small change

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Garma00 Garma00 marked this pull request as ready for review November 21, 2022 16:06
@Garma00 Garma00 requested a review from a team as a code owner November 21, 2022 16:06
@Garma00 Garma00 merged commit aa70806 into master Nov 23, 2022
@Garma00 Garma00 deleted the IOCIT-195 branch November 23, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopapi fabriziopapi fabriziopapi approved these changes

@gquadrati gquadrati gquadrati approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@domenicoventriglia domenicoventriglia Awaiting requested review from domenicoventriglia domenicoventriglia is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garma00 @pagopa-github-bot @gquadrati @fabriziopapi