[#169703944] Disable email channel if profile email is not validated #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 6 6
Lines 337 337
Branches 43 43
=======================================
Hits 283 283
Misses 53 53
Partials 1 1 |
gunzip
approved these changes
Nov 12, 2019
| @@ -157,6 +157,9 @@ export const getCreateNotificationActivityHandler = ( | |||
| // in their profile | |||
| const isEmailEnabledInProfile = profile.isEmailEnabled; | |||
|
|
|||
| // Check if the email in the user profile is validated | |||
| const isEmailValidatedInProfile = profile.isEmailValidated; | |||
There was a problem hiding this comment.
a question: is this set to true by default when using SPID login ?
There was a problem hiding this comment.
Yes on login the user profile is created with
- is_email_validated = true if logged in with SPID
- is_email_validated = false if logged in with CIE
francescopersico
deleted the
169703944-disable-email-channel-on-emailnotvalidated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.