Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPAE-169] Update IUploadServiceHandler/IUploadServiceLogoHandler for Manage flow #264

Merged
merged 2 commits into from
Feb 14, 2023
Merged

[#IOPAE-169] Update IUploadServiceHandler/IUploadServiceLogoHandler for Manage flow #264

merged 2 commits into from
Feb 14, 2023

Conversation

giuseppedipinto
Copy link
Contributor

@giuseppedipinto giuseppedipinto commented Feb 13, 2023 •
edited
Loading

Update IUploadServiceHandler/IUploadServiceLogoHandler for Manage flow.

List of Changes

  • UpdateService/UpdateServiceLogo API handlers

Motivation and Context

Added IAzureUserAttributesManage in IUploadServiceHandler/IUploadServiceLogoHandler attr parameter.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giuseppedipinto giuseppedipinto requested a review from a team as a code owner February 13, 2023 16:36
@github-actions
Copy link

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPAE-169

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@giuseppedipinto giuseppedipinto changed the title [#IOPAE-169] Bypass checkSourceIpForHandler for Manage flow [#IOPAE-169] Update IUploadServiceHandler/IUploadServiceLogoHandler for Manage flow Feb 14, 2023
@giuseppedipinto giuseppedipinto merged commit e7db6a8 into master Feb 14, 2023
@giuseppedipinto giuseppedipinto deleted the IOPAE-169--bypass-authorizedCIDRs-manage-flow branch February 14, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@LoFrance LoFrance Awaiting requested review from LoFrance

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuseppedipinto @balanza